{"componentChunkName":"component---node-modules-rocketseat-gatsby-theme-docs-core-src-templates-docs-query-js","path":"/code-style/Math-MHT","result":{"data":{"mdx":{"id":"aa75f66a-af18-5ef7-aa8c-33537aca636d","excerpt":"MHT-01C: Ineffectual Usage of Safe Arithmetics Type Severity Location Language Specific Math.sol:L47 ,  L51 ,  L78 ,  L154 ,  L162 Description: The linked…","fields":{"slug":"/code-style/Math-MHT/"},"frontmatter":{"title":"Math Code Style Findings","description":"Contains all the findings that relate to code style on the contract codebase","image":null,"disableTableOfContents":null},"body":"var _excluded = [\"components\"];\n\nfunction _extends() { _extends = Object.assign || function (target) { for (var i = 1; i < arguments.length; i++) { var source = arguments[i]; for (var key in source) { if (Object.prototype.hasOwnProperty.call(source, key)) { target[key] = source[key]; } } } return target; }; return _extends.apply(this, arguments); }\n\nfunction _objectWithoutProperties(source, excluded) { if (source == null) return {}; var target = _objectWithoutPropertiesLoose(source, excluded); var key, i; if (Object.getOwnPropertySymbols) { var sourceSymbolKeys = Object.getOwnPropertySymbols(source); for (i = 0; i < sourceSymbolKeys.length; i++) { key = sourceSymbolKeys[i]; if (excluded.indexOf(key) >= 0) continue; if (!Object.prototype.propertyIsEnumerable.call(source, key)) continue; target[key] = source[key]; } } return target; }\n\nfunction _objectWithoutPropertiesLoose(source, excluded) { if (source == null) return {}; var target = {}; var sourceKeys = Object.keys(source); var key, i; for (i = 0; i < sourceKeys.length; i++) { key = sourceKeys[i]; if (excluded.indexOf(key) >= 0) continue; target[key] = source[key]; } return target; }\n\n/* @jsxRuntime classic */\n\n/* @jsx mdx */\nvar _frontmatter = {\n  \"title\": \"Math Code Style Findings\",\n  \"description\": \"Contains all the findings that relate to code style on the contract codebase\"\n};\nvar layoutProps = {\n  _frontmatter: _frontmatter\n};\nvar MDXLayout = \"wrapper\";\nreturn function MDXContent(_ref) {\n  var components = _ref.components,\n      props = _objectWithoutProperties(_ref, _excluded);\n\n  return mdx(MDXLayout, _extends({}, layoutProps, props, {\n    components: components,\n    mdxType: \"MDXLayout\"\n  }), mdx(\"h2\", {\n    \"id\": \"span-idmht-01cmht-01c-ineffectual-usage-of-safe-arithmeticsspan\",\n    \"style\": {\n      \"position\": \"relative\"\n    }\n  }, mdx(\"a\", {\n    parentName: \"h2\",\n    \"href\": \"#span-idmht-01cmht-01c-ineffectual-usage-of-safe-arithmeticsspan\",\n    \"aria-label\": \"span idmht 01cmht 01c ineffectual usage of safe arithmeticsspan permalink\",\n    \"className\": \"anchor before\"\n  }, mdx(\"svg\", {\n    parentName: \"a\",\n    \"aria-hidden\": \"true\",\n    \"focusable\": \"false\",\n    \"height\": \"16\",\n    \"version\": \"1.1\",\n    \"viewBox\": \"0 0 16 16\",\n    \"width\": \"16\"\n  }, mdx(\"path\", {\n    parentName: \"svg\",\n    \"fillRule\": \"evenodd\",\n    \"d\": \"M4 9h1v1H4c-1.5 0-3-1.69-3-3.5S2.55 3 4 3h4c1.45 0 3 1.69 3 3.5 0 1.41-.91 2.72-2 3.25V8.59c.58-.45 1-1.27 1-2.09C10 5.22 8.98 4 8 4H4c-.98 0-2 1.22-2 2.5S3 9 4 9zm9-3h-1v1h1c1 0 2 1.22 2 2.5S13.98 12 13 12H9c-.98 0-2-1.22-2-2.5 0-.83.42-1.64 1-2.09V6.25c-1.09.53-2 1.84-2 3.25C6 11.31 7.55 13 9 13h4c1.45 0 3-1.69 3-3.5S14.5 6 13 6z\"\n  }))), mdx(\"span\", {\n    id: \"MHT-01C\"\n  }, \"MHT-01C: Ineffectual Usage of Safe Arithmetics\")), mdx(\"table\", null, mdx(\"thead\", {\n    parentName: \"table\"\n  }, mdx(\"tr\", {\n    parentName: \"thead\"\n  }, mdx(\"th\", {\n    parentName: \"tr\",\n    \"align\": null\n  }, \"Type\"), mdx(\"th\", {\n    parentName: \"tr\",\n    \"align\": null\n  }, \"Severity\"), mdx(\"th\", {\n    parentName: \"tr\",\n    \"align\": null\n  }, \"Location\"))), mdx(\"tbody\", {\n    parentName: \"table\"\n  }, mdx(\"tr\", {\n    parentName: \"tbody\"\n  }, mdx(\"td\", {\n    parentName: \"tr\",\n    \"align\": null\n  }, mdx(\"a\", {\n    parentName: \"td\",\n    \"href\": \"/reports/maverick-protocol-common-libraries-66165d178c7ae500187a1ad7/appendix/finding-types#language-specific\"\n  }, \"Language Specific\")), mdx(\"td\", {\n    parentName: \"tr\",\n    \"align\": null\n  }, mdx(\"img\", {\n    parentName: \"td\",\n    \"className\": \"o-severity o-informational\",\n    \"src\": \"https://omniscia.io/report-assets/informational.png\"\n  })), mdx(\"td\", {\n    parentName: \"tr\",\n    \"align\": null\n  }, mdx(\"a\", {\n    parentName: \"td\",\n    \"href\": \"https://github.com/maverickprotocol/maverick-v2/blob/47287a62e15ca8d4bcabf7e0b6757debb5d10593/v2-common/contracts/libraries/Math.sol#L47\"\n  }, \"Math.sol:L47\"), \", \", mdx(\"a\", {\n    parentName: \"td\",\n    \"href\": \"https://github.com/maverickprotocol/maverick-v2/blob/47287a62e15ca8d4bcabf7e0b6757debb5d10593/v2-common/contracts/libraries/Math.sol#L51\"\n  }, \"L51\"), \", \", mdx(\"a\", {\n    parentName: \"td\",\n    \"href\": \"https://github.com/maverickprotocol/maverick-v2/blob/47287a62e15ca8d4bcabf7e0b6757debb5d10593/v2-common/contracts/libraries/Math.sol#L78\"\n  }, \"L78\"), \", \", mdx(\"a\", {\n    parentName: \"td\",\n    \"href\": \"https://github.com/maverickprotocol/maverick-v2/blob/47287a62e15ca8d4bcabf7e0b6757debb5d10593/v2-common/contracts/libraries/Math.sol#L154\"\n  }, \"L154\"), \", \", mdx(\"a\", {\n    parentName: \"td\",\n    \"href\": \"https://github.com/maverickprotocol/maverick-v2/blob/47287a62e15ca8d4bcabf7e0b6757debb5d10593/v2-common/contracts/libraries/Math.sol#L162\"\n  }, \"L162\"))))), mdx(\"h3\", {\n    \"id\": \"description\",\n    \"style\": {\n      \"position\": \"relative\"\n    }\n  }, mdx(\"a\", {\n    parentName: \"h3\",\n    \"href\": \"#description\",\n    \"aria-label\": \"description permalink\",\n    \"className\": \"anchor before\"\n  }, mdx(\"svg\", {\n    parentName: \"a\",\n    \"aria-hidden\": \"true\",\n    \"focusable\": \"false\",\n    \"height\": \"16\",\n    \"version\": \"1.1\",\n    \"viewBox\": \"0 0 16 16\",\n    \"width\": \"16\"\n  }, mdx(\"path\", {\n    parentName: \"svg\",\n    \"fillRule\": \"evenodd\",\n    \"d\": \"M4 9h1v1H4c-1.5 0-3-1.69-3-3.5S2.55 3 4 3h4c1.45 0 3 1.69 3 3.5 0 1.41-.91 2.72-2 3.25V8.59c.58-.45 1-1.27 1-2.09C10 5.22 8.98 4 8 4H4c-.98 0-2 1.22-2 2.5S3 9 4 9zm9-3h-1v1h1c1 0 2 1.22 2 2.5S13.98 12 13 12H9c-.98 0-2-1.22-2-2.5 0-.83.42-1.64 1-2.09V6.25c-1.09.53-2 1.84-2 3.25C6 11.31 7.55 13 9 13h4c1.45 0 3-1.69 3-3.5S14.5 6 13 6z\"\n  }))), \"Description:\"), mdx(\"p\", null, \"The linked mathematical operation is guaranteed to be performed safely by surrounding conditionals evaluated in either \", mdx(\"inlineCode\", {\n    parentName: \"p\"\n  }, \"require\"), \" checks or \", mdx(\"inlineCode\", {\n    parentName: \"p\"\n  }, \"if-else\"), \" constructs.\"), mdx(\"h3\", {\n    \"id\": \"example\",\n    \"style\": {\n      \"position\": \"relative\"\n    }\n  }, mdx(\"a\", {\n    parentName: \"h3\",\n    \"href\": \"#example\",\n    \"aria-label\": \"example permalink\",\n    \"className\": \"anchor before\"\n  }, mdx(\"svg\", {\n    parentName: \"a\",\n    \"aria-hidden\": \"true\",\n    \"focusable\": \"false\",\n    \"height\": \"16\",\n    \"version\": \"1.1\",\n    \"viewBox\": \"0 0 16 16\",\n    \"width\": \"16\"\n  }, mdx(\"path\", {\n    parentName: \"svg\",\n    \"fillRule\": \"evenodd\",\n    \"d\": \"M4 9h1v1H4c-1.5 0-3-1.69-3-3.5S2.55 3 4 3h4c1.45 0 3 1.69 3 3.5 0 1.41-.91 2.72-2 3.25V8.59c.58-.45 1-1.27 1-2.09C10 5.22 8.98 4 8 4H4c-.98 0-2 1.22-2 2.5S3 9 4 9zm9-3h-1v1h1c1 0 2 1.22 2 2.5S13.98 12 13 12H9c-.98 0-2-1.22-2-2.5 0-.83.42-1.64 1-2.09V6.25c-1.09.53-2 1.84-2 3.25C6 11.31 7.55 13 9 13h4c1.45 0 3-1.69 3-3.5S14.5 6 13 6z\"\n  }))), \"Example:\"), mdx(\"pre\", null, mdx(\"code\", {\n    parentName: \"pre\",\n    \"className\": \"language-sol\",\n    \"metastring\": \"title=v2-common/contracts/libraries/Math.sol highlight={3,9} lineNumbers=true lineOffset=69\",\n    \"title\": \"v2-common/contracts/libraries/Math.sol\",\n    \"highlight\": \"{3,9}\",\n    \"lineNumbers\": \"true\",\n    \"lineOffset\": \"69\"\n  }, \"function invFloor(uint256 x) internal pure returns (uint256) {\\n    unchecked {\\n        return 1e36 / x;\\n    }\\n}\\n\\nfunction invCeil(uint256 x) internal pure returns (uint256 result) {\\n    result = invFloor(x);\\n    if (mulmod(ONE, ONE, x) != 0) result = result + 1;\\n}\\n\")), mdx(\"h3\", {\n    \"id\": \"recommendation\",\n    \"style\": {\n      \"position\": \"relative\"\n    }\n  }, mdx(\"a\", {\n    parentName: \"h3\",\n    \"href\": \"#recommendation\",\n    \"aria-label\": \"recommendation permalink\",\n    \"className\": \"anchor before\"\n  }, mdx(\"svg\", {\n    parentName: \"a\",\n    \"aria-hidden\": \"true\",\n    \"focusable\": \"false\",\n    \"height\": \"16\",\n    \"version\": \"1.1\",\n    \"viewBox\": \"0 0 16 16\",\n    \"width\": \"16\"\n  }, mdx(\"path\", {\n    parentName: \"svg\",\n    \"fillRule\": \"evenodd\",\n    \"d\": \"M4 9h1v1H4c-1.5 0-3-1.69-3-3.5S2.55 3 4 3h4c1.45 0 3 1.69 3 3.5 0 1.41-.91 2.72-2 3.25V8.59c.58-.45 1-1.27 1-2.09C10 5.22 8.98 4 8 4H4c-.98 0-2 1.22-2 2.5S3 9 4 9zm9-3h-1v1h1c1 0 2 1.22 2 2.5S13.98 12 13 12H9c-.98 0-2-1.22-2-2.5 0-.83.42-1.64 1-2.09V6.25c-1.09.53-2 1.84-2 3.25C6 11.31 7.55 13 9 13h4c1.45 0 3-1.69 3-3.5S14.5 6 13 6z\"\n  }))), \"Recommendation:\"), mdx(\"p\", null, \"Given that safe arithmetics are toggled on by default in \", mdx(\"inlineCode\", {\n    parentName: \"p\"\n  }, \"pragma\"), \" versions of \", mdx(\"inlineCode\", {\n    parentName: \"p\"\n  }, \"0.8.X\"), \", we advise the linked statement to be wrapped in an \", mdx(\"inlineCode\", {\n    parentName: \"p\"\n  }, \"unchecked\"), \" code block thereby optimizing its execution cost.\"), mdx(\"h3\", {\n    \"id\": \"alleviation-175f8c39b19df69134add3aa8a2a042ce3047763\",\n    \"style\": {\n      \"position\": \"relative\"\n    }\n  }, mdx(\"a\", {\n    parentName: \"h3\",\n    \"href\": \"#alleviation-175f8c39b19df69134add3aa8a2a042ce3047763\",\n    \"aria-label\": \"alleviation 175f8c39b19df69134add3aa8a2a042ce3047763 permalink\",\n    \"className\": \"anchor before\"\n  }, mdx(\"svg\", {\n    parentName: \"a\",\n    \"aria-hidden\": \"true\",\n    \"focusable\": \"false\",\n    \"height\": \"16\",\n    \"version\": \"1.1\",\n    \"viewBox\": \"0 0 16 16\",\n    \"width\": \"16\"\n  }, mdx(\"path\", {\n    parentName: \"svg\",\n    \"fillRule\": \"evenodd\",\n    \"d\": \"M4 9h1v1H4c-1.5 0-3-1.69-3-3.5S2.55 3 4 3h4c1.45 0 3 1.69 3 3.5 0 1.41-.91 2.72-2 3.25V8.59c.58-.45 1-1.27 1-2.09C10 5.22 8.98 4 8 4H4c-.98 0-2 1.22-2 2.5S3 9 4 9zm9-3h-1v1h1c1 0 2 1.22 2 2.5S13.98 12 13 12H9c-.98 0-2-1.22-2-2.5 0-.83.42-1.64 1-2.09V6.25c-1.09.53-2 1.84-2 3.25C6 11.31 7.55 13 9 13h4c1.45 0 3-1.69 3-3.5S14.5 6 13 6z\"\n  }))), \"Alleviation (175f8c39b19df69134add3aa8a2a042ce3047763):\"), mdx(\"p\", null, \"All referenced arithmetic statements have been wrapped in an \", mdx(\"inlineCode\", {\n    parentName: \"p\"\n  }, \"unchecked\"), \" code block as advised, optimizing their gas cost.\"), mdx(ViewDiffButton, {\n    repoUrl: \"https://github.com/maverickprotocol/maverick-v2\",\n    mainHash: \"47287a62e15ca8d4bcabf7e0b6757debb5d10593\",\n    fixHash: \"175f8c39b19df69134add3aa8a2a042ce3047763\",\n    gitHubIssue: \"0\",\n    mdxType: \"ViewDiffButton\"\n  }), mdx(\"h2\", {\n    \"id\": \"span-idmht-02cmht-02c-potentially-confusing-terminologyspan\",\n    \"style\": {\n      \"position\": \"relative\"\n    }\n  }, mdx(\"a\", {\n    parentName: \"h2\",\n    \"href\": \"#span-idmht-02cmht-02c-potentially-confusing-terminologyspan\",\n    \"aria-label\": \"span idmht 02cmht 02c potentially confusing terminologyspan permalink\",\n    \"className\": \"anchor before\"\n  }, mdx(\"svg\", {\n    parentName: \"a\",\n    \"aria-hidden\": \"true\",\n    \"focusable\": \"false\",\n    \"height\": \"16\",\n    \"version\": \"1.1\",\n    \"viewBox\": \"0 0 16 16\",\n    \"width\": \"16\"\n  }, mdx(\"path\", {\n    parentName: \"svg\",\n    \"fillRule\": \"evenodd\",\n    \"d\": \"M4 9h1v1H4c-1.5 0-3-1.69-3-3.5S2.55 3 4 3h4c1.45 0 3 1.69 3 3.5 0 1.41-.91 2.72-2 3.25V8.59c.58-.45 1-1.27 1-2.09C10 5.22 8.98 4 8 4H4c-.98 0-2 1.22-2 2.5S3 9 4 9zm9-3h-1v1h1c1 0 2 1.22 2 2.5S13.98 12 13 12H9c-.98 0-2-1.22-2-2.5 0-.83.42-1.64 1-2.09V6.25c-1.09.53-2 1.84-2 3.25C6 11.31 7.55 13 9 13h4c1.45 0 3-1.69 3-3.5S14.5 6 13 6z\"\n  }))), mdx(\"span\", {\n    id: \"MHT-02C\"\n  }, \"MHT-02C: Potentially Confusing Terminology\")), mdx(\"table\", null, mdx(\"thead\", {\n    parentName: \"table\"\n  }, mdx(\"tr\", {\n    parentName: \"thead\"\n  }, mdx(\"th\", {\n    parentName: \"tr\",\n    \"align\": null\n  }, \"Type\"), mdx(\"th\", {\n    parentName: \"tr\",\n    \"align\": null\n  }, \"Severity\"), mdx(\"th\", {\n    parentName: \"tr\",\n    \"align\": null\n  }, \"Location\"))), mdx(\"tbody\", {\n    parentName: \"table\"\n  }, mdx(\"tr\", {\n    parentName: \"tbody\"\n  }, mdx(\"td\", {\n    parentName: \"tr\",\n    \"align\": null\n  }, mdx(\"a\", {\n    parentName: \"td\",\n    \"href\": \"/reports/maverick-protocol-common-libraries-66165d178c7ae500187a1ad7/appendix/finding-types#code-style\"\n  }, \"Code Style\")), mdx(\"td\", {\n    parentName: \"tr\",\n    \"align\": null\n  }, mdx(\"img\", {\n    parentName: \"td\",\n    \"className\": \"o-severity o-informational\",\n    \"src\": \"https://omniscia.io/report-assets/informational.png\"\n  })), mdx(\"td\", {\n    parentName: \"tr\",\n    \"align\": null\n  }, mdx(\"a\", {\n    parentName: \"td\",\n    \"href\": \"https://github.com/maverickprotocol/maverick-v2/blob/47287a62e15ca8d4bcabf7e0b6757debb5d10593/v2-common/contracts/libraries/Math.sol#L158\"\n  }, \"Math.sol:L158\"), \", \", mdx(\"a\", {\n    parentName: \"td\",\n    \"href\": \"https://github.com/maverickprotocol/maverick-v2/blob/47287a62e15ca8d4bcabf7e0b6757debb5d10593/v2-common/contracts/libraries/Math.sol#L169\"\n  }, \"L169\"))))), mdx(\"h3\", {\n    \"id\": \"description-1\",\n    \"style\": {\n      \"position\": \"relative\"\n    }\n  }, mdx(\"a\", {\n    parentName: \"h3\",\n    \"href\": \"#description-1\",\n    \"aria-label\": \"description 1 permalink\",\n    \"className\": \"anchor before\"\n  }, mdx(\"svg\", {\n    parentName: \"a\",\n    \"aria-hidden\": \"true\",\n    \"focusable\": \"false\",\n    \"height\": \"16\",\n    \"version\": \"1.1\",\n    \"viewBox\": \"0 0 16 16\",\n    \"width\": \"16\"\n  }, mdx(\"path\", {\n    parentName: \"svg\",\n    \"fillRule\": \"evenodd\",\n    \"d\": \"M4 9h1v1H4c-1.5 0-3-1.69-3-3.5S2.55 3 4 3h4c1.45 0 3 1.69 3 3.5 0 1.41-.91 2.72-2 3.25V8.59c.58-.45 1-1.27 1-2.09C10 5.22 8.98 4 8 4H4c-.98 0-2 1.22-2 2.5S3 9 4 9zm9-3h-1v1h1c1 0 2 1.22 2 2.5S13.98 12 13 12H9c-.98 0-2-1.22-2-2.5 0-.83.42-1.64 1-2.09V6.25c-1.09.53-2 1.84-2 3.25C6 11.31 7.55 13 9 13h4c1.45 0 3-1.69 3-3.5S14.5 6 13 6z\"\n  }))), \"Description:\"), mdx(\"p\", null, \"The \", mdx(\"a\", {\n    parentName: \"p\",\n    \"href\": \"https://github.com/maverickprotocol/maverick-v2/blob/47287a62e15ca8d4bcabf7e0b6757debb5d10593/v2-common/contracts/libraries/Math.sol#L158-L167\"\n  }, mdx(\"inlineCode\", {\n    parentName: \"a\"\n  }, \"Math::toScale\")), \" and \", mdx(\"a\", {\n    parentName: \"p\",\n    \"href\": \"https://github.com/maverickprotocol/maverick-v2/blob/47287a62e15ca8d4bcabf7e0b6757debb5d10593/v2-common/contracts/libraries/Math.sol#L169-L175\"\n  }, mdx(\"inlineCode\", {\n    parentName: \"a\"\n  }, \"Math::fromScale\")), \" functions are slightly contradictory in their terminology, as the \", mdx(\"a\", {\n    parentName: \"p\",\n    \"href\": \"https://github.com/maverickprotocol/maverick-v2/blob/47287a62e15ca8d4bcabf7e0b6757debb5d10593/v2-common/contracts/libraries/Math.sol#L158-L167\"\n  }, mdx(\"inlineCode\", {\n    parentName: \"a\"\n  }, \"Math::toScale\")), \" function will convert an \", mdx(\"inlineCode\", {\n    parentName: \"p\"\n  }, \"amount\"), \" \", mdx(\"strong\", {\n    parentName: \"p\"\n  }, \"to its input \", mdx(\"inlineCode\", {\n    parentName: \"strong\"\n  }, \"scaleFactor\"), \" from the \\\"main\\\" \", mdx(\"inlineCode\", {\n    parentName: \"strong\"\n  }, \"1e18\"), \" scale\"), \" while the \", mdx(\"a\", {\n    parentName: \"p\",\n    \"href\": \"https://github.com/maverickprotocol/maverick-v2/blob/47287a62e15ca8d4bcabf7e0b6757debb5d10593/v2-common/contracts/libraries/Math.sol#L169-L175\"\n  }, mdx(\"inlineCode\", {\n    parentName: \"a\"\n  }, \"Math::fromScale\")), \" function will convert an \", mdx(\"inlineCode\", {\n    parentName: \"p\"\n  }, \"amount\"), \" \", mdx(\"strong\", {\n    parentName: \"p\"\n  }, \"to the \\\"main\\\" \", mdx(\"inlineCode\", {\n    parentName: \"strong\"\n  }, \"1e18\"), \" scale from its input \", mdx(\"inlineCode\", {\n    parentName: \"strong\"\n  }, \"scaleFactor\")), \".\"), mdx(\"h3\", {\n    \"id\": \"example-1\",\n    \"style\": {\n      \"position\": \"relative\"\n    }\n  }, mdx(\"a\", {\n    parentName: \"h3\",\n    \"href\": \"#example-1\",\n    \"aria-label\": \"example 1 permalink\",\n    \"className\": \"anchor before\"\n  }, mdx(\"svg\", {\n    parentName: \"a\",\n    \"aria-hidden\": \"true\",\n    \"focusable\": \"false\",\n    \"height\": \"16\",\n    \"version\": \"1.1\",\n    \"viewBox\": \"0 0 16 16\",\n    \"width\": \"16\"\n  }, mdx(\"path\", {\n    parentName: \"svg\",\n    \"fillRule\": \"evenodd\",\n    \"d\": \"M4 9h1v1H4c-1.5 0-3-1.69-3-3.5S2.55 3 4 3h4c1.45 0 3 1.69 3 3.5 0 1.41-.91 2.72-2 3.25V8.59c.58-.45 1-1.27 1-2.09C10 5.22 8.98 4 8 4H4c-.98 0-2 1.22-2 2.5S3 9 4 9zm9-3h-1v1h1c1 0 2 1.22 2 2.5S13.98 12 13 12H9c-.98 0-2-1.22-2-2.5 0-.83.42-1.64 1-2.09V6.25c-1.09.53-2 1.84-2 3.25C6 11.31 7.55 13 9 13h4c1.45 0 3-1.69 3-3.5S14.5 6 13 6z\"\n  }))), \"Example:\"), mdx(\"pre\", null, mdx(\"code\", {\n    parentName: \"pre\",\n    \"className\": \"language-sol\",\n    \"metastring\": \"title=v2-common/contracts/libraries/Math.sol highlight={1,12} lineNumbers=true lineOffset=157\",\n    \"title\": \"v2-common/contracts/libraries/Math.sol\",\n    \"highlight\": \"{1,12}\",\n    \"lineNumbers\": \"true\",\n    \"lineOffset\": \"157\"\n  }, \"function toScale(uint256 amount, uint256 scaleFactor, bool ceil) internal pure returns (uint256 z) {\\n    if (scaleFactor == DEFAULT_SCALE || amount == 0) {\\n        return amount;\\n    } else {\\n        if (!ceil) return amount / scaleFactor;\\n        assembly (\\\"memory-safe\\\") {\\n            z := add(div(sub(amount, 1), scaleFactor), 1)\\n        }\\n    }\\n}\\n\\nfunction fromScale(uint256 amount, uint256 scaleFactor) internal pure returns (uint256) {\\n    if (scaleFactor == DEFAULT_SCALE) {\\n        return amount;\\n    } else {\\n        return amount * scaleFactor;\\n    }\\n}\\n\")), mdx(\"h3\", {\n    \"id\": \"recommendation-1\",\n    \"style\": {\n      \"position\": \"relative\"\n    }\n  }, mdx(\"a\", {\n    parentName: \"h3\",\n    \"href\": \"#recommendation-1\",\n    \"aria-label\": \"recommendation 1 permalink\",\n    \"className\": \"anchor before\"\n  }, mdx(\"svg\", {\n    parentName: \"a\",\n    \"aria-hidden\": \"true\",\n    \"focusable\": \"false\",\n    \"height\": \"16\",\n    \"version\": \"1.1\",\n    \"viewBox\": \"0 0 16 16\",\n    \"width\": \"16\"\n  }, mdx(\"path\", {\n    parentName: \"svg\",\n    \"fillRule\": \"evenodd\",\n    \"d\": \"M4 9h1v1H4c-1.5 0-3-1.69-3-3.5S2.55 3 4 3h4c1.45 0 3 1.69 3 3.5 0 1.41-.91 2.72-2 3.25V8.59c.58-.45 1-1.27 1-2.09C10 5.22 8.98 4 8 4H4c-.98 0-2 1.22-2 2.5S3 9 4 9zm9-3h-1v1h1c1 0 2 1.22 2 2.5S13.98 12 13 12H9c-.98 0-2-1.22-2-2.5 0-.83.42-1.64 1-2.09V6.25c-1.09.53-2 1.84-2 3.25C6 11.31 7.55 13 9 13h4c1.45 0 3-1.69 3-3.5S14.5 6 13 6z\"\n  }))), \"Recommendation:\"), mdx(\"p\", null, \"As both the scale of the token and the scale of the system are \\\"scales\\\", we advise the functions to utilize different terminology (i.e. \", mdx(\"inlineCode\", {\n    parentName: \"p\"\n  }, \"normalize\"), \", \", mdx(\"inlineCode\", {\n    parentName: \"p\"\n  }, \"denormalize\"), \") that better illustrates their purpose.\"), mdx(\"p\", null, \"As the scale of the system (\", mdx(\"inlineCode\", {\n    parentName: \"p\"\n  }, \"1e18\"), \") represents a \\\"one-to-many\\\" relation between the scales of each token, the \", mdx(\"a\", {\n    parentName: \"p\",\n    \"href\": \"https://github.com/maverickprotocol/maverick-v2/blob/47287a62e15ca8d4bcabf7e0b6757debb5d10593/v2-common/contracts/libraries/Math.sol#L169-L175\"\n  }, mdx(\"inlineCode\", {\n    parentName: \"a\"\n  }, \"Math::fromScale\")), \" function should be considered to convert from the singular \", mdx(\"inlineCode\", {\n    parentName: \"p\"\n  }, \"1e18\"), \" project scale to the token's respective scale.\"), mdx(\"h3\", {\n    \"id\": \"alleviation-175f8c39b19df69134add3aa8a2a042ce3047763-1\",\n    \"style\": {\n      \"position\": \"relative\"\n    }\n  }, mdx(\"a\", {\n    parentName: \"h3\",\n    \"href\": \"#alleviation-175f8c39b19df69134add3aa8a2a042ce3047763-1\",\n    \"aria-label\": \"alleviation 175f8c39b19df69134add3aa8a2a042ce3047763 1 permalink\",\n    \"className\": \"anchor before\"\n  }, mdx(\"svg\", {\n    parentName: \"a\",\n    \"aria-hidden\": \"true\",\n    \"focusable\": \"false\",\n    \"height\": \"16\",\n    \"version\": \"1.1\",\n    \"viewBox\": \"0 0 16 16\",\n    \"width\": \"16\"\n  }, mdx(\"path\", {\n    parentName: \"svg\",\n    \"fillRule\": \"evenodd\",\n    \"d\": \"M4 9h1v1H4c-1.5 0-3-1.69-3-3.5S2.55 3 4 3h4c1.45 0 3 1.69 3 3.5 0 1.41-.91 2.72-2 3.25V8.59c.58-.45 1-1.27 1-2.09C10 5.22 8.98 4 8 4H4c-.98 0-2 1.22-2 2.5S3 9 4 9zm9-3h-1v1h1c1 0 2 1.22 2 2.5S13.98 12 13 12H9c-.98 0-2-1.22-2-2.5 0-.83.42-1.64 1-2.09V6.25c-1.09.53-2 1.84-2 3.25C6 11.31 7.55 13 9 13h4c1.45 0 3-1.69 3-3.5S14.5 6 13 6z\"\n  }))), \"Alleviation (175f8c39b19df69134add3aa8a2a042ce3047763):\"), mdx(\"p\", null, \"The referenced functions have been aptly renamed to indicate the conversion path they implement (i.e. \", mdx(\"inlineCode\", {\n    parentName: \"p\"\n  }, \"Math::ammScaleToTokenScale\"), \" and \", mdx(\"inlineCode\", {\n    parentName: \"p\"\n  }, \"Math::tokenScaleToAmmScale\"), \"), illustrating their intended usage and addressing the exhibit's concerns as a result.\"), mdx(ViewDiffButton, {\n    repoUrl: \"https://github.com/maverickprotocol/maverick-v2\",\n    mainHash: \"47287a62e15ca8d4bcabf7e0b6757debb5d10593\",\n    fixHash: \"175f8c39b19df69134add3aa8a2a042ce3047763\",\n    gitHubIssue: \"0\",\n    mdxType: \"ViewDiffButton\"\n  }), mdx(\"h2\", {\n    \"id\": \"span-idmht-03cmht-03c-repetitive-value-literalspan\",\n    \"style\": {\n      \"position\": \"relative\"\n    }\n  }, mdx(\"a\", {\n    parentName: \"h2\",\n    \"href\": \"#span-idmht-03cmht-03c-repetitive-value-literalspan\",\n    \"aria-label\": \"span idmht 03cmht 03c repetitive value literalspan permalink\",\n    \"className\": \"anchor before\"\n  }, mdx(\"svg\", {\n    parentName: \"a\",\n    \"aria-hidden\": \"true\",\n    \"focusable\": \"false\",\n    \"height\": \"16\",\n    \"version\": \"1.1\",\n    \"viewBox\": \"0 0 16 16\",\n    \"width\": \"16\"\n  }, mdx(\"path\", {\n    parentName: \"svg\",\n    \"fillRule\": \"evenodd\",\n    \"d\": \"M4 9h1v1H4c-1.5 0-3-1.69-3-3.5S2.55 3 4 3h4c1.45 0 3 1.69 3 3.5 0 1.41-.91 2.72-2 3.25V8.59c.58-.45 1-1.27 1-2.09C10 5.22 8.98 4 8 4H4c-.98 0-2 1.22-2 2.5S3 9 4 9zm9-3h-1v1h1c1 0 2 1.22 2 2.5S13.98 12 13 12H9c-.98 0-2-1.22-2-2.5 0-.83.42-1.64 1-2.09V6.25c-1.09.53-2 1.84-2 3.25C6 11.31 7.55 13 9 13h4c1.45 0 3-1.69 3-3.5S14.5 6 13 6z\"\n  }))), mdx(\"span\", {\n    id: \"MHT-03C\"\n  }, \"MHT-03C: Repetitive Value Literal\")), mdx(\"table\", null, mdx(\"thead\", {\n    parentName: \"table\"\n  }, mdx(\"tr\", {\n    parentName: \"thead\"\n  }, mdx(\"th\", {\n    parentName: \"tr\",\n    \"align\": null\n  }, \"Type\"), mdx(\"th\", {\n    parentName: \"tr\",\n    \"align\": null\n  }, \"Severity\"), mdx(\"th\", {\n    parentName: \"tr\",\n    \"align\": null\n  }, \"Location\"))), mdx(\"tbody\", {\n    parentName: \"table\"\n  }, mdx(\"tr\", {\n    parentName: \"tbody\"\n  }, mdx(\"td\", {\n    parentName: \"tr\",\n    \"align\": null\n  }, mdx(\"a\", {\n    parentName: \"td\",\n    \"href\": \"/reports/maverick-protocol-common-libraries-66165d178c7ae500187a1ad7/appendix/finding-types#code-style\"\n  }, \"Code Style\")), mdx(\"td\", {\n    parentName: \"tr\",\n    \"align\": null\n  }, mdx(\"img\", {\n    parentName: \"td\",\n    \"className\": \"o-severity o-informational\",\n    \"src\": \"https://omniscia.io/report-assets/informational.png\"\n  })), mdx(\"td\", {\n    parentName: \"tr\",\n    \"align\": null\n  }, mdx(\"a\", {\n    parentName: \"td\",\n    \"href\": \"https://github.com/maverickprotocol/maverick-v2/blob/47287a62e15ca8d4bcabf7e0b6757debb5d10593/v2-common/contracts/libraries/Math.sol#L72\"\n  }, \"Math.sol:L72\"), \", \", mdx(\"a\", {\n    parentName: \"td\",\n    \"href\": \"https://github.com/maverickprotocol/maverick-v2/blob/47287a62e15ca8d4bcabf7e0b6757debb5d10593/v2-common/contracts/libraries/Math.sol#L143\"\n  }, \"L143\"))))), mdx(\"h3\", {\n    \"id\": \"description-2\",\n    \"style\": {\n      \"position\": \"relative\"\n    }\n  }, mdx(\"a\", {\n    parentName: \"h3\",\n    \"href\": \"#description-2\",\n    \"aria-label\": \"description 2 permalink\",\n    \"className\": \"anchor before\"\n  }, mdx(\"svg\", {\n    parentName: \"a\",\n    \"aria-hidden\": \"true\",\n    \"focusable\": \"false\",\n    \"height\": \"16\",\n    \"version\": \"1.1\",\n    \"viewBox\": \"0 0 16 16\",\n    \"width\": \"16\"\n  }, mdx(\"path\", {\n    parentName: \"svg\",\n    \"fillRule\": \"evenodd\",\n    \"d\": \"M4 9h1v1H4c-1.5 0-3-1.69-3-3.5S2.55 3 4 3h4c1.45 0 3 1.69 3 3.5 0 1.41-.91 2.72-2 3.25V8.59c.58-.45 1-1.27 1-2.09C10 5.22 8.98 4 8 4H4c-.98 0-2 1.22-2 2.5S3 9 4 9zm9-3h-1v1h1c1 0 2 1.22 2 2.5S13.98 12 13 12H9c-.98 0-2-1.22-2-2.5 0-.83.42-1.64 1-2.09V6.25c-1.09.53-2 1.84-2 3.25C6 11.31 7.55 13 9 13h4c1.45 0 3-1.69 3-3.5S14.5 6 13 6z\"\n  }))), \"Description:\"), mdx(\"p\", null, \"The linked value literal is repeated across the codebase multiple times.\"), mdx(\"h3\", {\n    \"id\": \"example-2\",\n    \"style\": {\n      \"position\": \"relative\"\n    }\n  }, mdx(\"a\", {\n    parentName: \"h3\",\n    \"href\": \"#example-2\",\n    \"aria-label\": \"example 2 permalink\",\n    \"className\": \"anchor before\"\n  }, mdx(\"svg\", {\n    parentName: \"a\",\n    \"aria-hidden\": \"true\",\n    \"focusable\": \"false\",\n    \"height\": \"16\",\n    \"version\": \"1.1\",\n    \"viewBox\": \"0 0 16 16\",\n    \"width\": \"16\"\n  }, mdx(\"path\", {\n    parentName: \"svg\",\n    \"fillRule\": \"evenodd\",\n    \"d\": \"M4 9h1v1H4c-1.5 0-3-1.69-3-3.5S2.55 3 4 3h4c1.45 0 3 1.69 3 3.5 0 1.41-.91 2.72-2 3.25V8.59c.58-.45 1-1.27 1-2.09C10 5.22 8.98 4 8 4H4c-.98 0-2 1.22-2 2.5S3 9 4 9zm9-3h-1v1h1c1 0 2 1.22 2 2.5S13.98 12 13 12H9c-.98 0-2-1.22-2-2.5 0-.83.42-1.64 1-2.09V6.25c-1.09.53-2 1.84-2 3.25C6 11.31 7.55 13 9 13h4c1.45 0 3-1.69 3-3.5S14.5 6 13 6z\"\n  }))), \"Example:\"), mdx(\"pre\", null, mdx(\"code\", {\n    parentName: \"pre\",\n    \"className\": \"language-sol\",\n    \"metastring\": \"title=v2-common/contracts/libraries/Math.sol highlight={1} lineNumbers=true lineOffset=71\",\n    \"title\": \"v2-common/contracts/libraries/Math.sol\",\n    \"highlight\": \"{1}\",\n    \"lineNumbers\": \"true\",\n    \"lineOffset\": \"71\"\n  }, \"return 1e36 / x;\\n\")), mdx(\"h3\", {\n    \"id\": \"recommendation-2\",\n    \"style\": {\n      \"position\": \"relative\"\n    }\n  }, mdx(\"a\", {\n    parentName: \"h3\",\n    \"href\": \"#recommendation-2\",\n    \"aria-label\": \"recommendation 2 permalink\",\n    \"className\": \"anchor before\"\n  }, mdx(\"svg\", {\n    parentName: \"a\",\n    \"aria-hidden\": \"true\",\n    \"focusable\": \"false\",\n    \"height\": \"16\",\n    \"version\": \"1.1\",\n    \"viewBox\": \"0 0 16 16\",\n    \"width\": \"16\"\n  }, mdx(\"path\", {\n    parentName: \"svg\",\n    \"fillRule\": \"evenodd\",\n    \"d\": \"M4 9h1v1H4c-1.5 0-3-1.69-3-3.5S2.55 3 4 3h4c1.45 0 3 1.69 3 3.5 0 1.41-.91 2.72-2 3.25V8.59c.58-.45 1-1.27 1-2.09C10 5.22 8.98 4 8 4H4c-.98 0-2 1.22-2 2.5S3 9 4 9zm9-3h-1v1h1c1 0 2 1.22 2 2.5S13.98 12 13 12H9c-.98 0-2-1.22-2-2.5 0-.83.42-1.64 1-2.09V6.25c-1.09.53-2 1.84-2 3.25C6 11.31 7.55 13 9 13h4c1.45 0 3-1.69 3-3.5S14.5 6 13 6z\"\n  }))), \"Recommendation:\"), mdx(\"p\", null, \"We advise it to be set to a \", mdx(\"inlineCode\", {\n    parentName: \"p\"\n  }, \"constant\"), \" variable instead, optimizing the legibility of the codebase.\"), mdx(\"p\", null, \"In case the \", mdx(\"inlineCode\", {\n    parentName: \"p\"\n  }, \"constant\"), \" has already been declared, we advise it to be properly re-used across the code.\"), mdx(\"h3\", {\n    \"id\": \"alleviation-175f8c39b19df69134add3aa8a2a042ce3047763-2\",\n    \"style\": {\n      \"position\": \"relative\"\n    }\n  }, mdx(\"a\", {\n    parentName: \"h3\",\n    \"href\": \"#alleviation-175f8c39b19df69134add3aa8a2a042ce3047763-2\",\n    \"aria-label\": \"alleviation 175f8c39b19df69134add3aa8a2a042ce3047763 2 permalink\",\n    \"className\": \"anchor before\"\n  }, mdx(\"svg\", {\n    parentName: \"a\",\n    \"aria-hidden\": \"true\",\n    \"focusable\": \"false\",\n    \"height\": \"16\",\n    \"version\": \"1.1\",\n    \"viewBox\": \"0 0 16 16\",\n    \"width\": \"16\"\n  }, mdx(\"path\", {\n    parentName: \"svg\",\n    \"fillRule\": \"evenodd\",\n    \"d\": \"M4 9h1v1H4c-1.5 0-3-1.69-3-3.5S2.55 3 4 3h4c1.45 0 3 1.69 3 3.5 0 1.41-.91 2.72-2 3.25V8.59c.58-.45 1-1.27 1-2.09C10 5.22 8.98 4 8 4H4c-.98 0-2 1.22-2 2.5S3 9 4 9zm9-3h-1v1h1c1 0 2 1.22 2 2.5S13.98 12 13 12H9c-.98 0-2-1.22-2-2.5 0-.83.42-1.64 1-2.09V6.25c-1.09.53-2 1.84-2 3.25C6 11.31 7.55 13 9 13h4c1.45 0 3-1.69 3-3.5S14.5 6 13 6z\"\n  }))), \"Alleviation (175f8c39b19df69134add3aa8a2a042ce3047763):\"), mdx(\"p\", null, \"The referenced value literal \", mdx(\"inlineCode\", {\n    parentName: \"p\"\n  }, \"1e36\"), \" has been properly relocated to a file-level \", mdx(\"inlineCode\", {\n    parentName: \"p\"\n  }, \"constant\"), \" declaration labelled \", mdx(\"inlineCode\", {\n    parentName: \"p\"\n  }, \"ONE_SQUARED\"), \" within the \", mdx(\"inlineCode\", {\n    parentName: \"p\"\n  }, \"Constants\"), \" file, optimizing the code's legibility.\"), mdx(ViewDiffButton, {\n    repoUrl: \"https://github.com/maverickprotocol/maverick-v2\",\n    mainHash: \"47287a62e15ca8d4bcabf7e0b6757debb5d10593\",\n    fixHash: \"175f8c39b19df69134add3aa8a2a042ce3047763\",\n    gitHubIssue: \"0\",\n    mdxType: \"ViewDiffButton\"\n  }));\n}\n;\nMDXContent.isMDXComponent = true;","headings":[{"depth":2,"value":"<span id=\"MHT-01C\">MHT-01C: Ineffectual Usage of Safe Arithmetics</span>"},{"depth":3,"value":"Description:"},{"depth":3,"value":"Example:"},{"depth":3,"value":"Recommendation:"},{"depth":3,"value":"Alleviation (175f8c39b19df69134add3aa8a2a042ce3047763):"},{"depth":2,"value":"<span id=\"MHT-02C\">MHT-02C: Potentially Confusing Terminology</span>"},{"depth":3,"value":"Description:"},{"depth":3,"value":"Example:"},{"depth":3,"value":"Recommendation:"},{"depth":3,"value":"Alleviation (175f8c39b19df69134add3aa8a2a042ce3047763):"},{"depth":2,"value":"<span id=\"MHT-03C\">MHT-03C: Repetitive Value Literal</span>"},{"depth":3,"value":"Description:"},{"depth":3,"value":"Example:"},{"depth":3,"value":"Recommendation:"},{"depth":3,"value":"Alleviation (175f8c39b19df69134add3aa8a2a042ce3047763):"}]}},"pageContext":{"slug":"/code-style/Math-MHT/","prev":{"label":"Constants.sol (CST-C)","link":"/code-style/Constants-CST"},"next":{"label":"PoolLib.sol (PLB-C)","link":"/code-style/PoolLib-PLB"}}},"staticQueryHashes":["1954253342","2328931024","2501019404","973074209"]}